Re: [PATCH] usb mouse quirks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paolo Minazzi <paolo.minazzi@xxxxxxxxx> writes:

> [ text/plain ]
> Dear all,
> I have 3 wired usb optical mouse
> [1] Logitech 0x046D:0xC077
> [2] Logitech 0x046D:0xC05A
> [3] Microsoft 0x045E:0x0737
>
> I always used 3.10 kernel and all mice have the problem of
> disconnection after 62 seconds.
> I got the latest kernel 4.5-rc3 and I have discovered about quirks and
> HID_QUIRK_ALWAYS_POLL.
>
> Looking at the kernel 4.5-rc3 ...
>
> For [1] Logitech 0x046D:0xC077
> there is already a line in quirks
> { USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077, HID_QUIRK_ALWAYS_POLL }
> but the #define seems broken:
> #define USB_DEVICE_ID_LOGITECH_C077  0xc007

yeah, seems like that needs patching.

> Someone can confirm ?
>
> For [2] Logitech 0x046D:0xC05A all seems already ok. Quirk is already present.
>
> For [3] Microsoft 0x045E:0x0737 the support for HID_QUIRK_ALWAYS_POLL
> seems missing.
>
> The final patch should be (against 4.5-rc3) should be
>
> =========================================================================
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b6ff6e7..d788de2 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -600,7 +600,7 @@
>  #define USB_VENDOR_ID_LOGITECH         0x046d
>  #define USB_DEVICE_ID_LOGITECH_AUDIOHUB 0x0a0e
>  #define USB_DEVICE_ID_LOGITECH_T651    0xb00c
> -#define USB_DEVICE_ID_LOGITECH_C077    0xc007
> +#define USB_DEVICE_ID_LOGITECH_C077    0xc077
>  #define USB_DEVICE_ID_LOGITECH_RECEIVER        0xc101
>  #define USB_DEVICE_ID_LOGITECH_HARMONY_FIRST  0xc110
>  #define USB_DEVICE_ID_LOGITECH_HARMONY_LAST 0xc14f
> @@ -670,6 +670,7 @@
>
>  #define USB_VENDOR_ID_MICROSOFT                0x045e
>  #define USB_DEVICE_ID_SIDEWINDER_GV    0x003b
> +#define USB_DEVICE_ID_MS_MOUSE_500     0x0737
>  #define USB_DEVICE_ID_MS_OFFICE_KB     0x0048
>  #define USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0 0x009d
>  #define USB_DEVICE_ID_MS_NE4K          0x00db
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 7dd0953..09c8bed 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -93,6 +93,7 @@ static const struct hid_blacklist {
>         { USB_VENDOR_ID_MICROSOFT,
> USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
>         { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3,
> HID_QUIRK_NO_INIT_REPORTS },
>         { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER,
> HID_QUIRK_NO_INIT_REPORTS },
> +       { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_MOUSE_500,
> HID_QUIRK_ALWAYS_POLL },
>         { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL,
> HID_QUIRK_NO_INIT_REPORTS },
>         { USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750,
> HID_QUIRK_NO_INIT_REPORTS },
>         { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE,
> HID_QUIRK_NO_INIT_REPORTS },
> =========================================================================

patch looks okay to me, but you need to send it as a proper patch. Have
a look at Documentation/SubmittingPatches and that should answer all
your questions.

cheers

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux