On Sun, Feb 28, 2016 at 05:55:45PM +0000, Greg KH wrote: > On Sun, Feb 28, 2016 at 06:18:00PM +0100, Vittorio Alfieri wrote: > > On Sun, Feb 28, 2016 at 02:59:43AM +0000, Greg KH wrote: > > > On Sun, Feb 28, 2016 at 02:17:39AM +0100, Vittorio Alfieri wrote: > > > > The Parrot NMEA GPS Flight Recorder is a USB composite device consisting of hub, flash storage, and cp210x usb to serial chip. > > > > It is an accessory to the mass-produced Parrot AR Drone 2. > > > > The device emits standard NMEA messages which make the it compatible with NMEA compatible software. > > > > I tested using gpsd as an NMEA interpreter and the official Parrot Flight Recorder. > > > > It works with gpsd version 3.11-3. > > > > --- > > > > drivers/usb/serial/cp210x.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c > > > > index 987813b..ef422db 100644 > > > > --- a/drivers/usb/serial/cp210x.c > > > > +++ b/drivers/usb/serial/cp210x.c > > > > @@ -163,6 +163,7 @@ static const struct usb_device_id id_table[] = { > > > > { USB_DEVICE(0x1843, 0x0200) }, /* Vaisala USB Instrument Cable */ > > > > { USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */ > > > > { USB_DEVICE(0x18EF, 0xE025) }, /* ELV Marble Sound Board 1 */ > > > > + { USB_DEVICE(0x19CF, 0x3000) }, /* Parrot NMEA GPS Flight Recorder */ > > > > { USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */ > > > > { USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */ > > > > { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */ > > > > -- > > > > 2.1.4 > > > > > > You forgot a Signed-off-by: line, which is required for all changes, > > > please see Documenation/SubmittingPatches for what that is. > > > > > > Also please line-wrap your changelog comments at a sane column (i.e. 72, > > > you didn't pick anything...) > > > > > > thanks, > > > > > > greg k-h > > > > Hello, > > > > Thank you Greg for your fast answer and your suggestions. > > This is my first patch submitted for the linux kernel. > > > > I will submit a corrected patch in a separate email. > > Great. > > > BTW, is it possible to have this associated with my Github account for > > record keeping? > > I don't understand what you mean by this, please explain it more. > > greg k-h Hello, At risk of going completeley off-topic, I was wondering if it was possible and/or accepted practice to submit a pull-request through Github. Thank you, Vittorio -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html