Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 2/25/2016 11:55 AM, Petr Kulhavy wrote:

+#if IS_ENABLED(CONFIG_OF)
+/* gets the "mentor,power" property from DT
+ * and converts it from mA to 2mA units for the "power" parameter
+ * in struct musb_hdrc_platform_data
+ *
+ * in case the property is not found returns 0
+ */
+extern u8 musb_get_power(struct device *dev);
+#endif
+

   Now that you hard-coded the value, you don't need this function any more.

I have left it there so it can be used by the other drivers.

   I then fail to understand the logic behind hard coding.

And I fail to understand your plans with the other drivers.
Are you trying to say that the "mentor,power" (or "power" in OMAP2430)
property should be completely abandoned and the values hard coded in _all_
drivers?

   Contrariwise, I don't think it should be hard-coded anywhere.

Petr

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux