Petr Kulhavy <petr@xxxxxxxxx> writes:
> The musb_hdrc_platform_data::config was defined as a non-const pointer.
> However some drivers (e.g. the ux500) set up this pointer to point to a
> static structure, which is potentially dangerous. Since the musb core
> uses the pointer in a read-only manner the const qualifier was added to
> protect the content of the config.
>
> Signed-off-by: Petr Kulhavy <petr@xxxxxxxxx>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Bin, any inputs ?
> ---
> v5: <initial>
>
> v6:
> - whitespace formatting corrected
>
> v7: <no change>
>
> drivers/usb/musb/musb_core.c | 2 +-
> drivers/usb/musb/musb_core.h | 2 +-
> include/linux/usb/musb.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index ff7f5d0..7e94d65 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1938,7 +1938,7 @@ static void musb_recover_from_babble(struct musb *musb)
> */
>
> static struct musb *allocate_instance(struct device *dev,
> - struct musb_hdrc_config *config, void __iomem *mbase)
> + const struct musb_hdrc_config *config, void __iomem *mbase)
> {
> struct musb *musb;
> struct musb_hw_ep *ep;
> diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
> index c2ee702..1d57f5c 100644
> --- a/drivers/usb/musb/musb_core.h
> +++ b/drivers/usb/musb/musb_core.h
> @@ -438,7 +438,7 @@ struct musb {
> */
> unsigned double_buffer_not_ok:1;
>
> - struct musb_hdrc_config *config;
> + const struct musb_hdrc_config *config;
>
> int xceiv_old_state;
> #ifdef CONFIG_DEBUG_FS
> diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> index 96ddfb7..0b3da40 100644
> --- a/include/linux/usb/musb.h
> +++ b/include/linux/usb/musb.h
> @@ -124,7 +124,7 @@ struct musb_hdrc_platform_data {
> int (*set_power)(int state);
>
> /* MUSB configuration-specific details */
> - struct musb_hdrc_config *config;
> + const struct musb_hdrc_config *config;
>
> /* Architecture specific board data */
> void *board_data;
> --
> 1.9.1
>
--
balbi
Attachment:
signature.asc
Description: PGP signature
