Re: [PATCH] usblp.c: add USBLP_QUIRK_BIDIR to Brother HL-1440

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Monday 05 January 2009 17:51:53 schrieben Sie:
> On 17:41 Mon 05 Jan 2009, Oliver Neukum wrote:
> > Am Monday 05 January 2009 17:30:39 schrieb Brandon Philips:
> > > diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c
> > > index b5775af..3f3ee13 100644
> > > --- a/drivers/usb/class/usblp.c
> > > +++ b/drivers/usb/class/usblp.c
> > > @@ -226,6 +226,7 @@ static const struct quirk_printer_struct quirk_printers[] = {
> > >         { 0x0409, 0xf0be, USBLP_QUIRK_BIDIR }, /* NEC Picty920 (HP OEM) */
> > >         { 0x0409, 0xf1be, USBLP_QUIRK_BIDIR }, /* NEC Picty800 (HP OEM) */
> > >         { 0x0482, 0x0010, USBLP_QUIRK_BIDIR }, /* Kyocera Mita FS 820, by zut <kernel@xxxxxx> */
> > > +       { 0x04f9, 0x000d, USBLP_QUIRK_BIDIR }, /* Brother Industries, Ltd HL-1440 Laser Printer */
> > 
> > I remember that one from several bug reports. It has a questionable firmware.
> 
> Is that a ack of this patch then?!

As far as I am concerned, yes. Pete has to decide.

> Enabling this quirk seems to keep the firmware happy. Otherwise I have
> to unplug the device and plug it back in to get the next job in the
> queue to print.

Sorry, I meant to say that I would not waste more than the minimum
effort required to make this hardware work on a basic level. It is known to
be problematic.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux