Re: [PATCH 02/21] usb: add HAS_IOMEM dependency to USB_NET2272

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 10, 2016 at 03:29:37PM +0100, Vegard Nossum wrote:
> drivers/usb/gadget/udc/net2272.c: In function ‘net2272_remove’:
> drivers/usb/gadget/udc/net2272.c:2232:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(dev->base_addr);
>   ^
> drivers/usb/gadget/udc/net2272.c: In function ‘net2272_plat_probe’:
> drivers/usb/gadget/udc/net2272.c:2650:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>   dev->base_addr = ioremap_nocache(base, len);
>   ^
> drivers/usb/gadget/udc/net2272.c:2650:17: warning: assignment makes pointer from integer without a cast [enabled by default]
>   dev->base_addr = ioremap_nocache(base, len);
>                  ^
> 
> Signed-off-by: Vegard Nossum <vegard.nossum@xxxxxxxxxx>
> ---
>  drivers/usb/gadget/udc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 753c29b..ca19f6f 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -287,6 +287,7 @@ config USB_FSL_QE
>  	   dynamically linked module called "fsl_qe_udc".
>  
>  config USB_NET2272
> +	depends on HAS_IOMEM

Why not fix the root of the problem and provide the correct functions
for this when HAS_IOMEM is not enabled?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux