> > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > index d064ba8..22cd49b 100644
> > --- a/drivers/usb/dwc3/dwc3-pci.c
> > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > @@ -47,6 +47,14 @@ static const struct acpi_gpio_mapping acpi_dwc3_byt_gpios[] = {
> >
> > static int dwc3_pci_quirks(struct pci_dev *pdev, struct platform_device *dwc3)
> > {
> > + struct property_entry pentry[] = {
> > + PROPERTY_ENTRY_BOOL("snps,usb3_lpm_capable"),
> > + PROPERTY_ENTRY_BOOL("snps,has-lpm-erratum"),
> > + PROPERTY_ENTRY_BOOL("snps,dis_enblslpm_quirk"),
> > + { },
> > + };
> > + return platform_device_add_properties(dwc3, pentry);
> > +
> > if (pdev->vendor == PCI_VENDOR_ID_AMD &&
> > pdev->device == PCI_DEVICE_ID_AMD_NL_USB) {
> > struct property_entry pentry[] = {
>
>
> Are you sure about this chunk? It doesn't compile as there is no
> 'dwc3' argument in dwc3_pci_quirks() and the
> platform_device_add_properties() wants a property_set. Your original
> patch had it going through dwc3_pci_add_pset().
Sorry, I prepared that on top of my working branch which has some
extra stuff without thinking..
> Below is the patch I used to try to verify on latest.
>
> Any other ideas?
I can reproduce this now when the device does not have primary fwnode
(of_node or ACPI). Everything seems to work fine if there is the
primary fwnode and when the build-in properties are used as the
secondary fwnode (fallback).
This is a regression in drivers/base/property.c. Thanks for the
report. I'll try to prepare a fix for it today. I'll let you know
then so you can test it.
Thanks,
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
