Re: [PATCHv2 1/2] usb: dwc3: pci: use build-in properties instead of platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/2016 12:26 AM, Heikki Krogerus wrote:
> Hi John,
> 
>>> @@ -114,16 +117,14 @@ static int dwc3_pci_quirks(struct pci_dev *pdev)
>>>  	    (pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 ||
>>>  	     pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI ||
>>>  	     pdev->device == PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31)) {
>>> -
>>> -		struct dwc3_platform_data pdata;
>>> -
>>> -		memset(&pdata, 0, sizeof(pdata));
>>> -		pdata.usb3_lpm_capable = true;
>>> -		pdata.has_lpm_erratum = true;
>>> -		pdata.dis_enblslpm_quirk = true;
>>> -
>>> -		return platform_device_add_data(pci_get_drvdata(pdev), &pdata,
>>> -						sizeof(pdata));
>>> +		struct property_entry pentry[] = {
>>> +			PROPERTY_ENTRY_BOOL("snps,usb3_lpm_capable"),
>>> +			PROPERTY_ENTRY_BOOL("snps,has-lpm-erratum"),
>>> +			PROPERTY_ENTRY_BOOL("snps,dis_enblslpm_quirk"),
>>
>> I tried testing in Synopsys HAPS platform.
>>
>> The properties are being set here successfully but when queried in
>> core.c they all report 0.
>>
>> Any ideas?
> 
> How are you testing that? I just tested those properties with
> linux-next and:
> 

My baseline was Felipe's testing/next branch. Perhaps I need something
in linux-next? I'll try it out later today.

Regards,
John

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux