On Friday 05 February 2016 14:11:25 Peter Chen wrote: > On Thu, Feb 04, 2016 at 11:44:50AM +0100, Philipp Zabel wrote: > > Am Montag, den 25.01.2016, 15:24 +0800 schrieb Peter Chen: > > > diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt > > > new file mode 100644 > > > index 0000000..c702885 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/usb-device.txt > > > @@ -0,0 +1,25 @@ > > > +Generic USB Device Properties > > > + > > > +Usually, we only use device tree for hard wired USB device. > > > +The reference binding doc is from: > > > +http://www.firmware.org/1275/bindings/usb/usb-1_0.ps > > > + > > > +Required properties: > > > +- compatible: usbVID,PID > > > > The reference recommendation states that for single-configuration USB > > devices the compatible should contain all of the applicable strings from > > the list starting with 2) "usbVID,PID.REV" and ending with 11) > > "usb,device". Are we going to ignore this? > > > > I have not seen benefits if we write several compatibles in dts, > the information of compatibles listed in doc can be got during > the enumeration. > > I suggest we use the simple pattern for this compatible, in that > case, every one can be easy to follow it, and will not be confused > which compatibles should be used, and the style can be unify. It seems fine, as we don't expect any OS to ever use the compatible strings for binding to the driver. I think you should add a sentence to explain this, and maybe clarify that the compatible strings from the standard binding may also be used, but that a device adhering to this binding may leave out all except for usbVID,PID > > > > > + compatible = "usb05e3,0608"; > > > + reg = <0x1>; > > > + }; > > > > I'd have written this node as: > > > > hub: hub@1 { > > compatible = "usb5e3,608", "usb5e3,class9", > > "usb,class9", "usb,device"; > > reg = <1>; > > }; > > The reg should be hexadecimal, do we need to add "0x" before the value? The formatting of the numbers in properties is not normative, either one works and has the same meaning. I would leave out the leading 0x here too, as we are just enumerating the ports. I don't think that any USB hub has more than 9 ports, so it's not ambiguous to the reader. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
