Re: ehci-orion does not set USB mode for DT devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16.01.2016 18:31, Andrew Lunn wrote:
> Do you know anything about this?

Yes. There is no Linux drivers for the USB PHYs past Kirkwood and
Orion and no support for the DT boards at all. If the bootloader does
not set up the PHYs prior booting Linux ehci-orion will just hang.
I haven't investigated why it hangs.

> On Sat, Jan 09, 2016 at 03:51:51AM +0100, Phil Sutter wrote:
>> While porting mainline U-Boot to the Synology DS414 NAS, I noticed that
>> usb_add_hcd() fails if the single USB port's mode wasn't set previously
>> by U-Boot.

What SoC is DS414 based upon?

>> I tracked down the problem to ehci_orion_drv_probe(), which does not
>> call orion_usb_phy_v1_setup() for devices exported by DT. It looks like
>> this is intentional, so my question is: Should Linux set the mode
>> (ideally based on dr_mode DT attribute) or is this supposed to be done
>> by the boot loader?

I sent a patch set once for barebox to add (DT) support for the USB
PHYs for Orion up to Armada 370/XP. I lost track of it and it is not
likely I can get spare time to work on it in the near future.

I'll have to look at ehci-orion and if it does support attaching PHYs
easily. Reworking the barebox drivers for Linux should be easy at least
for Orion, Kirkwood, and Dove. Armada 370/XP have indirect register
access for the PHYs, that requires some more thinking when it comes to
the cleanest binding.

I see if I can send a quick RFC the next days. If not, I'll dig out the
link to the original patch set.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux