Hi Balbi, Thanks for your review and feedback. I will remove WARN_ON() as in your feedback. I will wait some days to see if any more comments before sending out an updated patch. Thanks, Thang Q. Nguyen On Sat, Jan 16, 2016 at 10:28 AM, Felipe Balbi <balbi@xxxxxxxxxx> wrote: > > Hi, > > "Thang Q. Nguyen" <tqnguyen@xxxxxxx> writes: >> Hi Balbi, >> >> On Thu, Jan 14, 2016 at 10:47 PM, Felipe Balbi <balbi@xxxxxxxxxx> wrote: >>> >>> >>> Hi, >>> >>> "Thang Q. Nguyen" <tqnguyen@xxxxxxx> writes: >>> > Add 64-bit DMA operation support to the USB DWC3 driver. >>> > First attempt to set the coherent DMA mask for 64-bit DMA. >>> > If that failed, attempt again with 32-bit DMA. >>> > >>> > Signed-off-by: Thang Q. Nguyen <tqnguyen@xxxxxxx> >>> > --- >>> > drivers/usb/dwc3/core.c | 15 +++++++++++++++ >>> > 1 file changed, 15 insertions(+) >>> > >>> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >>> > index 22b47973..9818d6b 100644 >>> > --- a/drivers/usb/dwc3/core.c >>> > +++ b/drivers/usb/dwc3/core.c >>> > @@ -829,6 +829,21 @@ static int dwc3_probe(struct platform_device *pdev) >>> > dwc->mem = mem; >>> > dwc->dev = dev; >>> > >>> > + /* Try to set 64-bit DMA first */ >>> > + if (WARN_ON(!pdev->dev.dma_mask)) >>> >>> why the WARN_ON() ? >> >> In my opinion, pdev->dev.dma_mask is expected to be set correctly. And > > sure is, but a WARN_ON() will print out a stack dump, which looks > scary. Besides, if it's not set you're already fixing the problem. > >> the issue happen just in case of DT boot and CONFIG_DMA_CMA=n, the >> pdev->dev.dma_mask value is not set. So, I set WARN_ON there to notify > > why isn't it set ? > >> that we expect pdev->dev.dma_mask set but not. > > why don't you fix that case, instead ? > > -- > balbi -- Thang Q. Nguyen | Staff SW Eng. C: +849.7684.7606 | O: +848.3770.0640 F: +848.3770.0641 | tqnguyen@xxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
