Hi, "Tang, Jianqiang" <jianqiang.tang@xxxxxxxxx> writes: > [PATCH] usb: dwc3: gadget: set the OTG flag in dwc3 gadget driver. This is not how a patch is supposed to be sent. If you want to send a new version of the patch as a reply to a previous version, please use git send-email --in-reply-to. In its current form, this line above will appear as is on commit log. Also, there should've been a patch version on subject line: [PATCH v2 1/1] ... > This patch is needed in order to pass one test case > defined in the OTG Automated Compliance Test specification. > > Specification location: > http://www.usb.org/developers/onthego/otgeh_compliance_plan_1_2.pdf > > This test case uses PET Tool, and PET Tool is one USB hardware > equipment provided by MQP Electronics. > > Test case id is 6.8.3 B-UUT Bypass Capacitance. > > We must set this otg flag in order to be able to return OTG > descriptor during enumeration, otherwise this test case with > failed with below error: "Get OTG descriptor request stalled". > > Signed-off-by: Jianqiang Tang <jianqiang.tang@xxxxxxxxx> > --- Then right here we should have a small history of the patchset: Changes since v1: - remove the if () conditional for in favor of a comparison > drivers/usb/dwc3/gadget.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index a58376f..955122c 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2748,6 +2748,7 @@ int dwc3_gadget_init(struct dwc3 *dwc) > dwc->gadget.speed = USB_SPEED_UNKNOWN; > dwc->gadget.sg_supported = true; > dwc->gadget.name = "dwc3-gadget"; > + dwc->gadget.is_otg = dwc->dr_mode == USB_DR_MODE_OTG; > > /* > * FIXME We might be setting max_speed to <SUPER, however versions > -- > 1.9.1 > > > -----Original Message----- > From: Felipe Balbi [mailto:balbif@xxxxxxxxx] On Behalf Of Felipe Balbi > Sent: Thursday, January 14, 2016 2:16 AM > To: Tang, Jianqiang <jianqiang.tang@xxxxxxxxx>; Jianqiang Tang <jianqiang.tang.kernel@xxxxxxxxx>; Felipe Balbi <balbi@xxxxxx>; linux-usb@xxxxxxxxxxxxxxx > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Tang, Jianqiang <jianqiang.tang@xxxxxxxxx> > Subject: RE: [PATCH 1/1] usb: dwc3: gadget: Set the OTG flag in dwc3 gadget driver. > > > Hi, > > "Tang, Jianqiang" <jianqiang.tang@xxxxxxxxx> writes: >> Set the otg flag during dwc3 gadget init function for ceritification >> test requirement. >> We must set this otg flag in order to be able to return OTG descriptor >> during enumeration. > > I forgot to comment this before, but can you add a reference to which test requires this ? Is it USBCV or some other test ? When refering to the test, please give us the proper test ID as well. Something like: > > "Set OTG flag during dwc3 gadget init function as requirement by Test TD x.y.z Test Description Here of the USB 3.0 Command Verifier (USB30CV) Test Suite" > > cheers > > -- > balbi -- balbi
Attachment:
signature.asc
Description: PGP signature
