Re: [PATCH] USB: serial: cp210x: Adding GPIO support for CP2105

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 13/01/16 10:49, Martyn Welch wrote:


On 13/01/16 10:42, kbuild test robot wrote:
Hi Martyn,

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on next-20160113]
[cannot apply to v4.4]
[if your patch is applied to the wrong git tree, please drop us a note
to help improving the system]

url:
https://github.com/0day-ci/linux/commits/Martyn-Welch/USB-serial-cp210x-Adding-GPIO-support-for-CP2105/20160113-183312

base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-randconfig-x018-01110856 (attached as .config)
reproduce:
         # save the attached .config to linux build tree
         make ARCH=x86_64

All error/warnings (new ones prefixed by >>):

drivers/usb/serial/cp210x.c:211:19: error: field 'gc' has incomplete
type
      struct gpio_chip gc;
                       ^

CONFIG_GPIOLIB isn't set in this build, which also reminds me that I
missed the GPIO maintainers off the patch submission :-(


...and it finally dawns on me that this is an issue.

Will fix.

Martyn

    In file included from drivers/usb/serial/cp210x.c:16:0:
    drivers/usb/serial/cp210x.c: In function 'cp210x_gpio_get':
    include/linux/kernel.h:813:48: warning: initialization from
incompatible pointer type [-Wincompatible-pointer-types]
      const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                    ^
drivers/usb/serial/cp210x.c:1017:5: note: in expansion of macro
'container_of'
         container_of(gc, struct cp210x_port_private, gc);
         ^
    include/linux/kernel.h:813:48: note: (near initialization for
'port_priv')
      const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                    ^
drivers/usb/serial/cp210x.c:1017:5: note: in expansion of macro
'container_of'
         container_of(gc, struct cp210x_port_private, gc);
         ^
    drivers/usb/serial/cp210x.c: In function 'cp210x_gpio_set':
    include/linux/kernel.h:813:48: warning: initialization from
incompatible pointer type [-Wincompatible-pointer-types]
      const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                    ^
    drivers/usb/serial/cp210x.c:1056:5: note: in expansion of macro
'container_of'
         container_of(gc, struct cp210x_port_private, gc);
         ^
    include/linux/kernel.h:813:48: note: (near initialization for
'port_priv')
      const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                    ^
    drivers/usb/serial/cp210x.c:1056:5: note: in expansion of macro
'container_of'
         container_of(gc, struct cp210x_port_private, gc);
         ^
    drivers/usb/serial/cp210x.c: In function 'cp210x_shared_gpio_init':
drivers/usb/serial/cp210x.c:1164:11: error: implicit declaration of
function 'gpiochip_add' [-Werror=implicit-function-declaration]
      result = gpiochip_add(&port_priv->gc);
               ^
    drivers/usb/serial/cp210x.c: In function 'cp210x_port_remove':
drivers/usb/serial/cp210x.c:1217:3: error: implicit declaration of
function 'gpiochip_remove' [-Werror=implicit-function-declaration]
       gpiochip_remove(&port_priv->gc);
       ^
    cc1: some warnings being treated as errors

vim +/gc +211 drivers/usb/serial/cp210x.c

    205    MODULE_DEVICE_TABLE(usb, id_table);
    206
    207    struct cp210x_port_private {
    208        __u8            bInterfaceNumber;
    209        bool            has_swapped_line_ctl;
    210        struct usb_serial    *serial;
  > 211        struct gpio_chip    gc;
    212    };
    213
    214    static struct usb_serial_driver cp210x_device = {

---
0-DAY kernel test infrastructure                Open Source Technology
Center
https://lists.01.org/pipermail/kbuild-all                   Intel
Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux