Re: [PATCH] usb: ehci: remove old stub_debug_files definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 8 Jan 2016, Geyslan G. Bem wrote:

> This patch removes the local STUB_DEBUG_FILES debugging
> definition. STUB_DEBUG_FILES was used only in ehci-hcd, whereas
> CONFIG_DYNAMIC_DEBUG is used all over the kernel.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
> ---
> 
> Notes:
>     This applies against "[PATCH resend 0/9] usb: host: ehci.h cleanup" and
>     "[PATCH v3 00/16] usb: host: ehci-dbg: cleanup and refactoring"
> 
>  drivers/usb/host/ehci-dbg.c | 4 ++--
>  drivers/usb/host/ehci.h     | 5 -----
>  2 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
> index d2c0711..79d12b2 100644
> --- a/drivers/usb/host/ehci-dbg.c
> +++ b/drivers/usb/host/ehci-dbg.c
> @@ -341,7 +341,7 @@ dbg_port(struct ehci_hcd *ehci, const char *label, int port, u32 status)
>  
>  /*-------------------------------------------------------------------------*/
>  
> -#ifdef STUB_DEBUG_FILES
> +#ifndef CONFIG_DYNAMIC_DEBUG
>  
>  static inline void create_debug_files(struct ehci_hcd *bus) { }
>  static inline void remove_debug_files(struct ehci_hcd *bus) { }
> @@ -1120,4 +1120,4 @@ static inline void remove_debug_files(struct ehci_hcd *ehci)
>  	debugfs_remove_recursive(ehci->debug_dir);
>  }
>  
> -#endif /* STUB_DEBUG_FILES */
> +#endif /* CONFIG_DYNAMIC_DEBUG */
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 7997b28..afcebd1 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -861,11 +861,6 @@ static inline u32 hc32_to_cpup(const struct ehci_hcd *ehci, const __hc32 *x)
>  #define ehci_warn(ehci, fmt, args...) \
>  	dev_warn(ehci_to_hcd(ehci)->self.controller, fmt, ## args)
>  
> -
> -#ifndef CONFIG_DYNAMIC_DEBUG
> -#define STUB_DEBUG_FILES
> -#endif
> -
>  /*-------------------------------------------------------------------------*/
>  
>  /* Declarations of things exported for use by ehci platform drivers */

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux