The file drivers/usb/misc/sisusbvga/sisusb.c had many (192) coding style issues reported by checkpatch. This file also had a problematic error path in the probe function that could result in dereferencing a null pointer. This patch series fix coding style issues and fix the problematic error path to avoid the null pointer dereference. Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c to verify that this patch do not change any visible character. If the size of this patch is a problem, please let me know in how many patches to split it. Patch 2 follows fixing trivial coding style, mostly related to braces, and parenthesis. Patch 3 remove assignments from if tests. Patch 4 remove calls to dev_err() on memory allocation failures and fix one error path to avoid dereferencing a null pointer. The patch change the problematic error path to cleanup previously allocated resources and abort the probe with -ENOMEM instead of only calling dev_err() and continue with the probe. Patch 5 remove null tests before calls to kfree(). Peter Senna Tschudin (5): usb-misc: sisusbvga: Fix coding style: white space usb-misc: sisusbvga: Fix coding style: braces, parenthesis, comment usb-misc: sisusbvga: Fix coding style: remove assignment from if tests usb-misc: sisusbvga: Remove memory allocation logs and fix error path usb-misc: sisusbvga: Remove null test before calls to kfree() drivers/usb/misc/sisusbvga/sisusb.c | 1543 +++++++++++++++++------------------ 1 file changed, 752 insertions(+), 791 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
