On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote: > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > > > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token) > > >> return '/'; > > >> } > > >> > > >> -static void qh_lines( > > >> - struct ehci_hcd *ehci, > > >> - struct ehci_qh *qh, > > >> - char **nextp, > > >> - unsigned *sizep > > >> -) > > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh, > > >> + char **nextp, unsigned *sizep) > > >> { > > >> u32 scratch; > > >> u32 hw_curr; > > >> > > > > > And about that style? Should be done? > > You mean squeezing the function parameters into two lines? That's > okay. > > However, the style in this file is to indent continuation lines by two > extra tab stops, not to line things up with an open paren on the first > line. It's not consistent. It's a bit of a mix of 1 and 2 tabs, and some others. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html