On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > 2016-01-04 18:01 GMT-03:00 Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>: > > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > > > >> This patch fixes a coding style issue reported by checkpatch related to > >> many leading tabs, removing a 'do while' loop and making use of goto tag instead. > > > > This is highly questionable. It's a big amount of code churn, nearly > > impossible to verify visually, just to remove one level of indentation. > > It also introduces an unnecessary backwards "goto", which seems like a > > bad idea. > After hear you I agree. I saw that others drivers uses similar > structure (fotg210-hcd.c and ohci-dbg.c), but they have less code. It > would be the case in this file of moving code to a new function? If > not, please disregard this patch. Moving code into a new sub-function would be okay. BTW, you don't need to post these patches to both linux-usb and LKML. linux-usb alone is good enough. Nothing about the patches would be especially interesting to a general Linux kernel programmer, so there's no point in bringing them to everybody's attention. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
