Hi, Here are the follow up commits proposed during last Johan review of the new mxu11x0 driver. I also patched a memory leak on usb_serial private data. In v2, I fixed the trivial issues reported by Johan in commits 1/4 and 4/4. About commit 2/4, I was wrong in last cover-letter message. The exact command order sniffed on Windows during opening is : SET_CONFIG (set_termios) -> OPEN_PORT -> START_PORT To be compliant, commit 2/4 only deletes duplicated OPEN_PORT and START_PORT commands. The new commit 3/4 deletes the duplicated set_termios in open callback. Thanks, Mathieu Mathieu OTHACEHE (4): USB: mxu11x0: fix memory leak on usb_serial private data USB: mxu11x0: clean device control commands USB: mxu11x0: remove duplicated set_termios call USB: mxu11x0: move firmware download and endpoint testing to probe callback drivers/usb/serial/mxu11x0.c | 171 ++++++++++++++++++++++++++----------------- 1 file changed, 104 insertions(+), 67 deletions(-) -- 2.6.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html