On Tue, Dec 29, 2015 at 09:19:29AM -0200, Fabio Estevam wrote: > On Tue, Dec 29, 2015 at 6:15 AM, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: > > > I prefer to keep it, and it let us know the existing issues although > > we have not implemented workaround for them. In future, we may have > > solutions for how to implement them. > > Ok, what about adding the recommendation below? > > --- a/drivers/usb/phy/phy-mxs-usb.c > +++ b/drivers/usb/phy/phy-mxs-usb.c > @@ -98,6 +98,9 @@ > * The PHY will be in messy if there is a wakeup after putting > * bus to suspend (set portsc.suspendM) but before setting PHY to low > * power mode (set portsc.phcd). > + * > + * To work around this problem on mx23/mx28 user should pass > + * 'usbcore.autosuspend=-1' in the kernel command line for now. > */ > #define MXS_PHY_ABNORMAL_IN_SUSPEND BIT(1) Good suggestion, one more you can add "before these flags are implemented" at your comment. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
