Re: [PATCH] usb: dwc2: gadget: don't overwrite DCTL register on NAKEFF interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2015 8:58 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Gregory Herrero <gregory.herrero@xxxxxxxxx> writes:
>> When receiving GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF interrupt,
>> DCTL will be overwritten with DCTL_CGOUTNAK or DCTL_CGNPINNAK values.
>> Instead of overwriting it, write only needed bits.
>>
>> It could cause an issue if GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF
>> interrupt is received after dwc2 disabled pullup by writing
>> DCTL_SFTDISCON bit.
>> Pullup will then be re-enabled whereas it should not.
>>
>> Signed-off-by: Gregory Herrero <gregory.herrero@xxxxxxxxx>
> 
> John, are you okay with this patch ?
> 


Acked-by: John Youn <johnyoun@xxxxxxxxxxxx>


John


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux