On Thu, Dec 10, 2015 at 09:56:24PM -0600, Rob Herring wrote:
> On Fri, Dec 11, 2015 at 11:12:26AM +0900, Simon Horman wrote:
> > Add fallback compatibility strings for R-Car Gen2 and Gen3.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> >
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>
> Binding looks okay, but one possible typo.
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
> > .compatible = "renesas,usbhs-r8a7795",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > },
> > + {
> > + .compatible = "renesas,rcar-gen2-usbhs",
> > + .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > + },
> > + {
> > + /* Gen3 is compatible with Gen2 */
> > + .compatible = "renesas,rcar-gen3-usbhs",
> > + .data = (void *)USBHS_TYPE_RCAR_GEN2,
>
> This supposed to be GEN3?
Confusingly the symbol is called GEN2 as it was there for Gen 2
before Gen 3 came along and (so far) Gen 3 is compatible with Gen 2.
I'd be happy to change the name but I think that would be best
as an incremental change on top of this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
