Re: [PATCH] usb: dwc3: gadget: pass a condition to dev_WARN_ONCE()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

kbuild test robot <lkp@xxxxxxxxx> writes:
> Hi Felipe,
>
> [auto build test ERROR on balbi-usb/next]
> [also build test ERROR on v4.4-rc4 next-20151210]
>
> url:    https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-dwc3-gadget-pass-a-condition-to-dev_WARN_ONCE/20151211-031232
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
> config: x86_64-randconfig-x015-12102221 (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
>
> All error/warnings (new ones prefixed by >>):
>
>    In file included from include/linux/linkage.h:4:0,
>                     from include/linux/kernel.h:6,
>                     from drivers/usb/dwc3/gadget.c:19:
>    drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_ep_disable':
>>> drivers/usb/dwc3/gadget.c:695:6: error: expected ')' before string constant
>          "%s is already disabled\n",
>          ^
>    include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p((cond)) ? !!(cond) :   \
>                                ^
>>> drivers/usb/dwc3/gadget.c:694:2: note: in expansion of macro 'if'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>      ^
>>> include/linux/device.h:1295:2: note: in expansion of macro 'WARN_ONCE'
>      WARN_ONCE(condition, "%s %s: " format, \
>  n    ^
>>> drivers/usb/dwc3/gadget.c:694:6: note: in expansion of macro 'dev_WARN_ONCE'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>          ^
>>> drivers/usb/dwc3/gadget.c:696:6: error: expected ')' before 'dep'
>          dep->name))
>          ^
>    include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p((cond)) ? !!(cond) :   \
>                                ^
>>> drivers/usb/dwc3/gadget.c:694:2: note: in expansion of macro 'if'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>      ^
>    include/linux/compiler.h:145:23: note: in expansion of macro '__trace_if'
>     #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
>                           ^
>    include/asm-generic/bug.h:124:3: note: in expansion of macro 'if'
>       if (WARN(!__warned, format))    \
>       ^
>    include/asm-generic/bug.h:97:3: note: in expansion of macro '__WARN_printf'
>       __WARN_printf(format);     \
>       ^
>    include/asm-generic/bug.h:124:7: note: in expansion of macro 'WARN'
>       if (WARN(!__warned, format))    \
>           ^
>>> include/linux/device.h:1295:2: note: in expansion of macro 'WARN_ONCE'
>      WARN_ONCE(condition, "%s %s: " format, \
>      ^
>>> drivers/usb/dwc3/gadget.c:694:6: note: in expansion of macro 'dev_WARN_ONCE'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>          ^
>>> include/linux/device.h:1295:23: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
>      WARN_ONCE(condition, "%s %s: " format, \
>                           ^
>    include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p((cond)) ? !!(cond) :   \
>                                ^
>>> drivers/usb/dwc3/gadget.c:694:2: note: in expansion of macro 'if'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>      ^
>    include/linux/compiler.h:145:23: note: in expansion of macro '__trace_if'
>     #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
>                           ^
>    include/asm-generic/bug.h:124:3: note: in expansion of macro 'if'
>       if (WARN(!__warned, format))    \
>       ^
>    include/asm-generic/bug.h:97:3: note: in expansion of macro '__WARN_printf'
>       __WARN_printf(format);     \
>       ^
>    include/asm-generic/bug.h:124:7: note: in expansion of macro 'WARN'
>       if (WARN(!__warned, format))    \
>           ^
>>> include/linux/device.h:1295:2: note: in expansion of macro 'WARN_ONCE'
>      WARN_ONCE(condition, "%s %s: " format, \
>      ^
>>> drivers/usb/dwc3/gadget.c:694:6: note: in expansion of macro 'dev_WARN_ONCE'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>          ^
>>> include/linux/device.h:1295:23: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
>      WARN_ONCE(condition, "%s %s: " format, \
>                           ^
>    include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p((cond)) ? !!(cond) :   \
>                                ^
>>> drivers/usb/dwc3/gadget.c:694:2: note: in expansion of macro 'if'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>      ^
>    include/linux/compiler.h:145:23: note: in expansion of macro '__trace_if'
>     #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
>                           ^
>    include/asm-generic/bug.h:124:3: note: in expansion of macro 'if'
>       if (WARN(!__warned, format))    \
>       ^
>    include/asm-generic/bug.h:97:3: note: in expansion of macro '__WARN_printf'
>       __WARN_printf(format);     \
>       ^
>    include/asm-generic/bug.h:124:7: note: in expansion of macro 'WARN'
>       if (WARN(!__warned, format))    \
>           ^
>>> include/linux/device.h:1295:2: note: in expansion of macro 'WARN_ONCE'
>      WARN_ONCE(condition, "%s %s: " format, \
>      ^
>>> drivers/usb/dwc3/gadget.c:694:6: note: in expansion of macro 'dev_WARN_ONCE'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>          ^
>>> drivers/usb/dwc3/gadget.c:696:6: error: expected ')' before 'dep'
>          dep->name))
>          ^
>    include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
>      if (__builtin_constant_p((cond)) ? !!(cond) :   \
>                                ^
>>> drivers/usb/dwc3/gadget.c:694:2: note: in expansion of macro 'if'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>      ^
>    include/linux/compiler.h:145:23: note: in expansion of macro '__trace_if'
>     #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
>                           ^
>    include/asm-generic/bug.h:124:3: note: in expansion of macro 'if'
>       if (WARN(!__warned, format))    \
>       ^
>    include/asm-generic/bug.h:97:3: note: in expansion of macro '__WARN_printf'
>       __WARN_printf(format);     \
>       ^
>    include/asm-generic/bug.h:124:7: note: in expansion of macro 'WARN'
>       if (WARN(!__warned, format))    \
>           ^
>>> include/linux/device.h:1295:2: note: in expansion of macro 'WARN_ONCE'
>      WARN_ONCE(condition, "%s %s: " format, \
>      ^
>>> drivers/usb/dwc3/gadget.c:694:6: note: in expansion of macro 'dev_WARN_ONCE'
>      if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>          ^
>
> vim +695 drivers/usb/dwc3/gadget.c
>
>    688			return -EINVAL;
>    689		}
>    690	
>    691		dep = to_dwc3_ep(ep);
>    692		dwc = dep->dwc;
>    693	
>  > 694		if (dev_WARN_ONCE(dwc->dev, !(dep->flags & DWC3_EP_ENABLED)
>  > 695						"%s is already disabled\n",
>  > 696						dep->name))

fixed in testing/next, thanks for reporting :-)

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux