Re: [PATCH 00/18] usb: dwc2: Reduce probe delays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



John,

On Wed, Dec 2, 2015 at 11:11 AM, John Youn <John.Youn@xxxxxxxxxxxx> wrote:
> This series includes patches that were submitted earlier by Douglas
> Anderson and Yunzhi Li to reduce delays during probe and get the
> correct reset values of the hardware configuration registers. These
> are patches 1-6 in this series.
>
> I have additionally added patches to clean up the code around that
> area, and have further reduced the delays by:
>
> - Taking into account the correct dr_mode
> - Skipping force mode when not needed
> - Removing unnecessary force mode from the gadget side
> - Reduce the force mode delay from 150 ms to 25 ms
>
> Tested on:
> - Synopsys HAPS, IP v3.20
> - Altera SOCFPGA, IP v2.93
>
> Appreciate testing on other platforms.
>
> Regards,
> John
>
> Douglas Anderson (4):
>   usb: dwc2: Restore GUSBCFG in dwc2_get_hwparams()
>   usb: dwc2: Avoid double-reset at boot time
>   usb: dwc2: Speed dwc2_get_hwparams() on some host-only ports
>   usb: dwc2: Avoid more calls to dwc2_core_reset()
>
> John Youn (12):
>   usb: dwc2: Reorder AHBIDLE and CSFTRST in dwc2_core_reset()
>   usb: dwc2: Rename dwc2_core_reset()
>   usb: dwc2: Add dwc2_core_reset()
>   usb: dwc2: Add functions to check the HW OTG config
>   usb: dwc2: Fix dr_mode validation
>   usb: dwc2: Move mode querying functions into core.h
>   usb: dwc2: Move reset into dwc2_get_hwparams()
>   usb: dwc2: Add functions to set and clear force mode
>   usb: dwc2: Improve handling of host and device hwparams
>   usb: dwc2: gadget: Use the common dwc2_core_reset()
>   usb: dwc2: gadget: Remove force device mode
>   usb: dwc2: Reduce delay when forcing mode in reset
>
> Yunzhi Li (2):
>   usb: dwc2: reset dwc2 core before dwc2_get_hwparams()
>   usb: dwc2: reduce dwc2 driver probe time
>
>  drivers/usb/dwc2/core.c     | 301 ++++++++++++++++++++++++++++++++++----------
>  drivers/usb/dwc2/core.h     |  30 ++++-
>  drivers/usb/dwc2/gadget.c   |  68 +---------
>  drivers/usb/dwc2/hcd.c      |   6 +-
>  drivers/usb/dwc2/hcd.h      |  12 --
>  drivers/usb/dwc2/platform.c |  81 ++++++++++--
>  6 files changed, 340 insertions(+), 158 deletions(-)

I confirmed that the first 6 patches match the last ones I posted.  As
you found, there was a trivial merge conflict with "usb: dwc2: reset
dwc2 core before dwc2_get_hwparams()" and you resolved it in the same
way that I resolved it locally.  I'm not sure tags like Tested-by or
Reviewed-by make sense for patches that I authored and/or have
Signed-off-by, but just noting that I'm OK with them as you've
reposted (thanks!)


I picked all the other patches locally to my 3.14 too and am testing.
So far so good.  I've got a farm of 5 devices doing reboot tests
overnight.  On each bootup it will confirm that a USB based Ethernet
adapter on one of the two ports is at least sane enough to get SSH
connections and that the device never crashes.

I'll send review feedback and tested-by for each patch (other than the
gadget ones, which I applied mostly to avoid merge conflicts) tomorrow
morning on the conclusion of the boot test.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux