Re: [PATCH] usb: gadget: f_tcm: ignore return value of queue_work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

[auto build test WARNING on next-20151209]
[cannot apply to balbi-usb/next usb/usb-testing v4.4-rc4 v4.4-rc3 v4.4-rc2 v4.4-rc4]

url:    https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/usb-gadget-f_tcm-ignore-return-value-of-queue_work/20151209-225509
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/usb/gadget/function/f_tcm.c: In function 'usbg_submit_command':
>> drivers/usb/gadget/function/f_tcm.c:1084:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret;
         ^
   drivers/usb/gadget/function/f_tcm.c: In function 'bot_submit_command':
   drivers/usb/gadget/function/f_tcm.c:1197:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret;
         ^

vim +/ret +1084 drivers/usb/gadget/function/f_tcm.c

b4b91143 Andrzej Pietrasiewicz 2015-10-27  1068  	return;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1069  
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1070  out:
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1071  	transport_send_check_condition_and_sense(se_cmd,
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1072  			TCM_UNSUPPORTED_SCSI_OPCODE, 1);
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1073  	usbg_cleanup_cmd(cmd);
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1074  }
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1075  
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1076  static int usbg_submit_command(struct f_uas *fu,
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1077  		void *cmdbuf, unsigned int len)
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1078  {
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1079  	struct command_iu *cmd_iu = cmdbuf;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1080  	struct usbg_cmd *cmd;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1081  	struct usbg_tpg *tpg;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1082  	struct tcm_usbg_nexus *tv_nexus;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1083  	u32 cmd_len;
b4b91143 Andrzej Pietrasiewicz 2015-10-27 @1084  	int ret;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1085  
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1086  	if (cmd_iu->iu_id != IU_ID_COMMAND) {
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1087  		pr_err("Unsupported type %d\n", cmd_iu->iu_id);
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1088  		return -EINVAL;
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1089  	}
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1090  
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1091  	cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC);
b4b91143 Andrzej Pietrasiewicz 2015-10-27  1092  	if (!cmd)

:::::: The code at line 1084 was first introduced by commit
:::::: b4b91143ec451471ab9bbb9966afc82ce92f65e8 usb: gadget: tcm: factor out f_tcm

:::::: TO: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
:::::: CC: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux