Felipe,
On 12/08/2015 09:05 AM, Bin Liu wrote:
Felipe,
On 12/08/2015 08:59 AM, Felipe Balbi wrote:
Hi,
Bin Liu <b-liu@xxxxxx> writes:
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 5b625e2..b33e00b 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -32,7 +32,7 @@ if USB_SUPPORT
config USB_COMMON
tristate
default y
- depends on USB || USB_GADGET || USB_OTG
+ depends on USB || USB_GADGET || USB_OTG || AM335X_PHY_USB
AM335X_PHY_USB can only be selected in case USB or USB_GADGET is
selected, right ? This extra depends here smells very fishy.
I will have to double check it again. I forgot what exact the issue was
when I was creating this patch. Without this depends, there was symbol
missing error when compile, I don't remember that was due to M or Y on
AM335x_PHY_USB or it was be disabled.
The AM335x_PHY_USB driver now calls of_usb_get_dr_mode_by_phy() defined
in USB_COMMON. With omap2plus_defconfig, AM335x_PHY_USB=y, but
USB_COMMON=m, which causes the phy driver is unable to find the function.
I will send v3 with the following instead.
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 793023e..f76c953 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -67,6 +67,7 @@ config AM335X_PHY_USB
select USB_PHY
select AM335X_CONTROL_USB
select NOP_USB_XCEIV
+ select USB_COMMON
help
This driver provides PHY support for that phy which part for the
AM335x SoC.
--
Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
