Re: [PATCH] Add support for usbfs zerocopy.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steinar,

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.4-rc3 next-20151203]

url:    https://github.com/0day-ci/linux/commits/Steinar-H-Gunderson/Add-support-for-usbfs-zerocopy/20151206-034258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-x006-201549 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/fs.h:4,
                    from drivers/usb/core/devio.c:37:
   drivers/usb/core/devio.c: In function 'proc_do_submiturb':
   include/linux/err.h:21:38: warning: comparison between pointer and integer
    #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
                                         ^
   include/linux/compiler.h:137:45: note: in definition of macro 'unlikely'
    #  define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
                                                ^
   drivers/usb/core/devio.c:1617:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(as->usbm)) {
         ^
   include/linux/err.h:21:38: warning: comparison between pointer and integer
    #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
                                         ^
   include/linux/compiler.h:137:53: note: in definition of macro 'unlikely'
    #  define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
                                                        ^
   drivers/usb/core/devio.c:1617:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(as->usbm)) {
         ^
   include/linux/err.h:21:38: warning: comparison between pointer and integer
    #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
                                         ^
   include/linux/compiler.h:110:47: note: in definition of macro 'likely_notrace'
    #define likely_notrace(x) __builtin_expect(!!(x), 1)
                                                  ^
   include/linux/compiler.h:137:58: note: in expansion of macro '__branch_check__'
    #  define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
                                                             ^
>> include/linux/err.h:21:25: note: in expansion of macro 'unlikely'
    #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
                            ^
   drivers/usb/core/devio.c:1617:6: note: in expansion of macro 'IS_ERR_VALUE'
     if (IS_ERR_VALUE(as->usbm)) {
         ^

vim +/unlikely +21 include/linux/err.h

a5ed3cee Joe Perches    2014-04-03   5  #include <linux/types.h>
^1da177e Linus Torvalds 2005-04-16   6  
^1da177e Linus Torvalds 2005-04-16   7  #include <asm/errno.h>
^1da177e Linus Torvalds 2005-04-16   8  
^1da177e Linus Torvalds 2005-04-16   9  /*
^1da177e Linus Torvalds 2005-04-16  10   * Kernel pointers have redundant information, so we can use a
a5ed3cee Joe Perches    2014-04-03  11   * scheme where we can return either an error code or a normal
^1da177e Linus Torvalds 2005-04-16  12   * pointer with the same return value.
^1da177e Linus Torvalds 2005-04-16  13   *
^1da177e Linus Torvalds 2005-04-16  14   * This should be a per-architecture thing, to allow different
^1da177e Linus Torvalds 2005-04-16  15   * error and pointer decisions.
^1da177e Linus Torvalds 2005-04-16  16   */
fa79837d Ralf Baechle   2006-07-01  17  #define MAX_ERRNO	4095
fa79837d Ralf Baechle   2006-07-01  18  
ebba5f9f Randy Dunlap   2006-09-27  19  #ifndef __ASSEMBLY__
ebba5f9f Randy Dunlap   2006-09-27  20  
fa79837d Ralf Baechle   2006-07-01 @21  #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
07ab67c8 Linus Torvalds 2005-05-19  22  
e47103b1 Jani Nikula    2010-05-24  23  static inline void * __must_check ERR_PTR(long error)
^1da177e Linus Torvalds 2005-04-16  24  {
^1da177e Linus Torvalds 2005-04-16  25  	return (void *) error;
^1da177e Linus Torvalds 2005-04-16  26  }
^1da177e Linus Torvalds 2005-04-16  27  
e7152b97 Dan Carpenter  2013-07-03  28  static inline long __must_check PTR_ERR(__force const void *ptr)
^1da177e Linus Torvalds 2005-04-16  29  {

:::::: The code at line 21 was first introduced by commit
:::::: fa79837d5b562766a3e3cfad4753a3df8e0a1319 [PATCH] Fix IS_ERR Threshold Value

:::::: TO: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux