Re: [PATCH v2] usb: dwc3: gadget: handle request->zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Robert Baldyga <r.baldyga@xxxxxxxxxxx> writes:
>> @@ -1171,6 +1197,17 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
>>  
>>  	spin_lock_irqsave(&dwc->lock, flags);
>>  	ret = __dwc3_gadget_ep_queue(dep, req);
>> +
>> +	/*
>> +	 * Okay, here's the thing, if gadget driver has requested for a ZLP by
>> +	 * setting request->zero, instead of doing magic, we will just queue an
>> +	 * extra usb_request ourselves so that it gets handled the same way as
>> +	 * any other request.
>> +	 */
>> +	if (ret == 0 && request->zero && (request->length % ep->maxpacket == 0))
>> +		ret = __dwc3_gadget_ep_queue_zlp(dwc, dep);
>> +
>> +out:
>
> This 'out' label is never used.

good catch. I'll remove it in v3. Thanks

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux