Re: [PATCH] usb: Add connected retry on resume for non SS devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Dec 2015, Al Cooper wrote:

> Currently usb_port_resume waits for up to 2 seconds for CONNECT
> status for SS devices only. This change will do the same thing for
> non-SS devices even though the reason is a little different. This
> will fix an issue where VBUS is turned off during system wide
> "suspend to ram" and some 2.0 devices take greater than the current
> max of 100ms to show connected after VBUS is enabled. This is most
> commonly seen on hard drive based devices and USB3.0 devices plugged
> into a 2.0 only port.
> 
> Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx>
> ---
>  drivers/usb/core/hub.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index bdeadc1..d32824b 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3322,7 +3322,7 @@ static int finish_port_resume(struct usb_device *udev)
>   * This routine should only be called when persist is enabled for a SS
>   * device.
>   */
> -static int wait_for_ss_port_enable(struct usb_device *udev,
> +static int wait_for_connected(struct usb_device *udev,
>  		struct usb_hub *hub, int *port1,
>  		u16 *portchange, u16 *portstatus)
>  {

Please update the comments at the head of this routine to match.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux