On Sat, Nov 28 2015, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote: > >>>> This file already uses pr_debug in a few places; this converts the >>>> remaining printks. >>> >>> Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent? >> >> Yes, and that is a good thing, you should be using pr_debug() instead of >> printk(KERN_DEBUG...). >> >> Why object to something like this? > > I'm not objecting, just asking. There have been many cases in my > practice where a patch author wasn't aware of that... I was aware, but I can see how the commit message could indicate otherwise. I don't feel strongly for the conversion, so I could redo 2/3 and 3/3 (which should be uncontroversial cleanups). Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
