Hi Mian,
Thank you for the patch.
On Saturday 28 November 2015 18:35:44 Mian Yousaf Kaukab wrote:
> 76e0da3 "usb-gadget/uvc: use per-attribute show and store methods"
> removed write permission for writeable attributes. Correct attribute
> permissions.
>
> Fixes: 76e0da3 "usb-gadget/uvc: use per-attribute show and store methods"
> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@xxxxxxxxx>
This looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/function/uvc_configfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/uvc_configfs.c
> b/drivers/usb/gadget/function/uvc_configfs.c index 289ebca..ad8c9b0 100644
> --- a/drivers/usb/gadget/function/uvc_configfs.c
> +++ b/drivers/usb/gadget/function/uvc_configfs.c
> @@ -20,7 +20,7 @@
> #define UVC_ATTR(prefix, cname, aname) \
> static struct configfs_attribute prefix##attr_##cname = { \
> .ca_name = __stringify(aname), \
> - .ca_mode = S_IRUGO, \
> + .ca_mode = S_IRUGO | S_IWUGO, \
> .ca_owner = THIS_MODULE, \
> .show = prefix##cname##_show, \
> .store = prefix##cname##_store, \
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
