Hi,
Stefan Wahren <info@xxxxxxxxxxxxxx> writes:
> Hi Felipe,
>
> Am 19.11.2015 um 20:54 schrieb Felipe Balbi:
>>
>> Hi John,
>>
>> John Youn <John.Youn@xxxxxxxxxxxx> writes:
>>> Fixes commit 09a75e85
>>> "usb: dwc2: refactor common low-level hw code to platform.c"
>>
>> these two lines should be placed ...
>>
>>>
>>> The above commit consolidated the low-level phy access into a common
>>> location. This change introduced a check from the gadget requiring
>>> that a PHY is specified. This requirement never existed on the host
>>> side and broke some platforms when it was moved into platform.c.
>>>
>>> The gadget doesn't require the PHY either so remove the check.
>>>
>>
>> ... here with the following format:
>>
>> Fixes: 09a75e857790 ("usb: dwc2: refactor common low-level
>> hw code to platform.c")
>>
>> Just is just FYI, as I have already applied another version ;-)
>>
>
> thanks but
>
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/log/?h=testing/fixes
>
> seems to miss ("usb: dwc2: fix kernel oops during driver probe")
This is what you gent for sending fixes and non-fixes in the same series
:-)
Also, this has been broken for a long time, you didn't include a "Fixes:
foo-bar-baz", you didn't Cc stable (seems like the regression is from
v3.19). It gets pretty difficult for me to apply patches properly if you
can't send them in a way I can understand what to do with them.
If you want patches to get into -rc, send the bare minimum patches
needed to fix the problem and do NOT make them depend on anything else.
> and
>
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/log/?h=testing/next
>
> seems to miss ("usb: dwc2: Return errors from PHY")
in my queue
> Maybe i forgot to mention that the patch series needs to be applied
> complete to fix the regression.
if you have dependencies within the series, let me know now.
--
balbi
Attachment:
signature.asc
Description: PGP signature
