Hi, "McCauley, Ben" <Ben.McCauley@xxxxxxxxxx> writes: <snip> >> Ben, can you respin your patch to also add the comment explaining the >> situation so we don't loose track of it ? Then I can apply once -rc1 is out. >> >> thanks >> >> -- >> Balbi > > The max speed was always being set to USB_SUPER_SPEED > even when the phy was only capable of HIGH_SPEED. This > uses the value set for the phy to set the max for the > gadget. It resolves an issue with Window PCs where they > report that using a USB3.0 port would result in better > performance even when connecting through a 3.0 port. A > follow on patch will be needed to add USB_SPEED_HIGH_LPM > to support High Speed devices which also support LPM. > > Signed-off-by: McCauley, Ben <ben.mccauley@xxxxxxxxxx> if I were to apply this patch, all of those hundreds of lines of context in the email would go into the git log. This is not how you send a patch. > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 1eaf31c..342be2f 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2899,7 +2899,15 @@ > } > > dwc->gadget.ops = &dwc3_gadget_ops; > - dwc->gadget.max_speed = USB_SPEED_SUPER; > + /* > + * FIXME A new enumeration USB_SPEED_HIGH_LPM needs to be added > + * to support USB 2.10. Setting max_speed to dwc->maximum_speed > + * disables LPM support for devices which do not support > + * SuperSpeed but are LPM capable. > + */ > + if (dwc->maximum_speed < USB_SPEED_SUPER) > + dev_info(dwc->dev, "SuperSpeed not supported.\n"); > + dwc->gadget.max_speed = dwc->maximum_speed; > dwc->gadget.speed = USB_SPEED_UNKNOWN; > dwc->gadget.sg_supported = true; > dwc->gadget.name = "dwc3-gadget" > > ________________________________ > > CONFIDENTIALITY NOTICE: This email and any attachments are for the > sole use of the intended recipient(s) and contain information that may > be confidential and/or legally privileged. If you have received this > email in error, please notify the sender by reply email and delete the > message. Any disclosure, copying, distribution or use of this > communication (including attachments) by someone other than the > intended recipient is prohibited. Thank you. this note, as I have said before, should not be in your email anymore, much less in git's history. I'll all of these while applying, but it's the only time; next time, sorry, I'll have to ignore your patch until you manage to get it done correct. regards -- balbi
Attachment:
signature.asc
Description: PGP signature
