On Thu, Nov 12, 2015 at 11:07 AM, dave penkler <dpenkler@xxxxxxxxx> wrote: > Thanks for your comments, I will resubmit taking into account all > suggestions. > >> > - redundant parens Example 1. + (atomic_read(&data->iin_data_valid) != 0), >> > - pieces of code takes whole line when they are quite fit tail of >> > previous one. >> > > > > I have endeavoured to follow the coding style of the original driver and > stick to the kernel coding-style guidelines. > Please point to the specific locations where I have failed to do so. Example 1. + dev_err(dev, "control status returned %x\n", + buffer[0]); example 2. + USBTMC_TIMEOUT + ); -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html