Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 11/11/2015 10:03 PM, Andy Shevchenko wrote:

Background:
When performing a read on an instrument that is executing a function
that runs longer than the USB timeout the instrument may hang and require
a device reset to recover. The READ_STATUS_BYTE operation always returns
even when the instrument is busy permitting to poll for the appropriate
condition. This capability is refered to in instrument application notes

   Referred.

on synchronizing acquisitions for other platforms.

Won't comment precisely by line, but common nitpicks about style:
  - added empty lines where no need
  - redundant parens
  - pieces of code takes whole line when they are quite fit tail of previous one.

And why malloc for 8 bytes?

   To be able to do DMA with this buffer, apparently.

Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx>

[patch skipped]

It's a good tone to skip the parts you're not commenting on, so others wouldn't have to scroll in vain.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux