Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/06/2015 01:23 PM, Alan Stern wrote:
On Fri, 6 Nov 2015, Bin Liu wrote:

This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77.

Commit 20357720 claims throughput improvement for MSC/UVC, but I
don't see much improvement. Following are the MSC measurement using
dd on AM335x GP EVM.

with BCD_BH:    read: 14.9MB/s, write: 20.9MB/s
without BCD_BH: read: 15.2MB/s, write: 21.2MB/s

However with this commit the following regressions have been observed.

1. ASIX usb-ethernet dongle is completely broken on UDP RX.

2. Unpluging a 3G modem, which uses option driver, behind a hub causes
    console log flooding with the following message.

    option_instat_callback: error -71

Did you do any debugging to figure out why these problems occur with
HCD_BH but don't occur without it?

No, I never got a chance to debug it, but I am wondering if something causes the BH does not get a chance to execute...

I should have mentioned that both cases failed in PIO mode too, so not CPPI related.

BTY, the TI kernel prior to mainline 3.12+ does not use HCD_BH in musb driver.

Regards,
-Bin.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux