Re: [PATCH] usb: storage: scsiglue: increase transfer size limit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 29, 2015 at 02:00:57PM -0700, Matthew Dharm wrote:
> IIRC, the sysfs attribute doesn't exist until after the device is
> probed, and the SCSI probing might fail (can't read partition tables,
> leading to errors, catastrophic failure) if the max-sectors is too
> high during probing.
> 
> While I agree 20-25% performance gain is significant, a high
> failure-rate is also significant.  And, while it's been many years, do
> *you* want to field all the e-mails from people who say the device
> they've been using for years is suddenly dead?
> 
> I think the best compromise is to only adjust the limit up for USB 3
> devices.  That pretty much guarantees a "newer" device, which should
> hopefully behave better.

I agree, this seems like the "safest" thing to do, we can't break any
old devices.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux