Hello, On Fri, Oct 16, 2015 at 6:19 AM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: [...] >> >> @@ -249,6 +251,16 @@ static struct usb_serial_driver * const >> serial_drivers[] = { >> #define CP210X_GET_CHARS 0x0E >> #define CP210X_GET_PROPS 0x0F >> #define CP210X_GET_COMM_STATUS 0x10 >> +/* Data returned by CP210X_GET_COMM_STATUS -- h/w doc says it's 0x13 >> bytes */ >> +struct cp210x_comm_status { >> + u32 errors; >> + u32 hold_reasons; >> + u32 amount_in_in_queue; >> + u32 amount_in_out_queue; >> + u8 eof_received; >> + u8 wait_for_immediate; >> + u8 reserved; >> +}; > > > Please don't declare structures amidst of the command #define's. > [...] I agree with all suggestions except this one. I find it very convenient, when reading code, to have the command code and its data declared in the same place. Best regards, Konstantin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html