Hi,
Bart Van Assche <bart.vanassche@xxxxxxxxxxx> writes:
> Avoid that building with W=1 triggers compiler warnings about
> set-but-not-used variables.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxx>
> Cc: Andy Grover <agrover@xxxxxxxxxx>
I think this has no dependencies on the previous series, but it's also
not a major patch. I'm fine if you guys wanna take this through FS tree.
Just one note, make sure to Cc linux-usb. get_maintainer.pl should be
telling you to do so.
Acked-by: Felipe Balbi <balbi@xxxxxx>
> ---
> drivers/usb/gadget/legacy/tcm_usb_gadget.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/usb/gadget/legacy/tcm_usb_gadget.c b/drivers/usb/gadget/legacy/tcm_usb_gadget.c
> index 33833fe..ddef0c5 100644
> --- a/drivers/usb/gadget/legacy/tcm_usb_gadget.c
> +++ b/drivers/usb/gadget/legacy/tcm_usb_gadget.c
> @@ -71,18 +71,9 @@ static void bot_enqueue_sense_code(struct f_uas *fu, struct usbg_cmd *cmd)
> {
> struct bulk_cs_wrap *csw = &fu->bot_status.csw;
> int ret;
> - u8 *sense;
> unsigned int csw_stat;
>
> csw_stat = cmd->csw_code;
> -
> - /*
> - * We can't send SENSE as a response. So we take ASC & ASCQ from our
> - * sense buffer and queue it and hope the host sends a REQUEST_SENSE
> - * command where it learns why we failed.
> - */
> - sense = cmd->sense_iu.sense;
> -
> csw->Tag = cmd->bot_tag;
> csw->Status = csw_stat;
> fu->bot_status.req->context = cmd;
> @@ -1078,7 +1069,6 @@ static int usbg_submit_command(struct f_uas *fu,
> struct command_iu *cmd_iu = cmdbuf;
> struct usbg_cmd *cmd;
> struct usbg_tpg *tpg;
> - struct se_cmd *se_cmd;
> struct tcm_usbg_nexus *tv_nexus;
> u32 cmd_len;
> int ret;
> @@ -1142,7 +1132,6 @@ static int usbg_submit_command(struct f_uas *fu,
> break;
> }
>
> - se_cmd = &cmd->se_cmd;
> cmd->unpacked_lun = scsilun_to_int(&cmd_iu->lun);
>
> INIT_WORK(&cmd->work, usbg_cmd_work);
> @@ -1195,7 +1184,6 @@ static int bot_submit_command(struct f_uas *fu,
> struct bulk_cb_wrap *cbw = cmdbuf;
> struct usbg_cmd *cmd;
> struct usbg_tpg *tpg;
> - struct se_cmd *se_cmd;
> struct tcm_usbg_nexus *tv_nexus;
> u32 cmd_len;
> int ret;
> @@ -1236,7 +1224,6 @@ static int bot_submit_command(struct f_uas *fu,
> }
>
> cmd->prio_attr = TCM_SIMPLE_TAG;
> - se_cmd = &cmd->se_cmd;
> cmd->unpacked_lun = cbw->Lun;
> cmd->is_read = cbw->Flags & US_BULK_FLAG_IN ? 1 : 0;
> cmd->data_len = le32_to_cpu(cbw->DataTransferLength);
> --
> 2.1.4
>
--
balbi
Attachment:
signature.asc
Description: PGP signature
