Re: [PATCH 12/14] usb: dwc2: host: avoid usage of dma_alloc_coherent with irqs disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 12, 2015 at 03:09:40PM +0800, kbuild test robot wrote:
> Hi Gregory,
> 
> [auto build test ERROR on balbi-usb/next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> 
> config: i386-randconfig-r0-201541 (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/usb/dwc2/core.c: In function 'dwc2_hc_start_transfer_ddma':
> >> drivers/usb/dwc2/core.c:1941:47: error: 'struct dwc2_hsotg' has no member named 'frame_list_dma'
>       dma_sync_single_for_device(hsotg->dev, hsotg->frame_list_dma,
>                                                   ^
> >> drivers/usb/dwc2/core.c:1942:14: error: 'struct dwc2_hsotg' has no member named 'frame_list_sz'
>             hsotg->frame_list_sz, DMA_TO_DEVICE);
>                  ^
> 
> vim +1941 drivers/usb/dwc2/core.c
> 

This call of dma_sync_single_for_device() is not needed here because
hsotg->frame_list buffer is already synced in dwc2_update_frame_list().
I will remove it in the next patchset revision.

>   1935	
>   1936		dwc2_writel(hctsiz, hsotg->regs + HCTSIZ(chan->hc_num));
>   1937	
>   1938		/* Sync frame list only for periodics channels */
>   1939		if (chan->ep_type == USB_ENDPOINT_XFER_ISOC ||
>   1940		    chan->ep_type == USB_ENDPOINT_XFER_INT)
> > 1941			dma_sync_single_for_device(hsotg->dev, hsotg->frame_list_dma,
> > 1942						   hsotg->frame_list_sz, DMA_TO_DEVICE);
>   1943	
>   1944		dma_sync_single_for_device(hsotg->dev, chan->desc_list_addr,
>   1945					   chan->desc_list_sz, DMA_TO_DEVICE);
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux