Re: [PATCH 2/3] xhci: handle no ping response error properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10.10.2015 00:45, Paul Zimmerman wrote:
Sorry, resending as plain text.

On Fri, Oct 9, 2015, Mathias Nyman wrote:

+ handling_skipped_tds = ep->skip &&
+ (trb_comp_code != COMP_MISSED_INT ||
    ^^
I think this should be &&, shouldn't it?

+  trb_comp_code != COMP_PING_ERR);


Oh, yes, that's right. Now the part after "&&" is always true.
We want to handle the skipped TDs if ep->skip is set, AND current event its not a MISSED interval,
AND not a PING error

Thanḱs for spotting this, I'll resend

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux