RE: [PATCH 1/4] usb: host: xhci-rcar: add xhci_rcar_is_compatible() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

> Sent: Tuesday, October 06, 2015 5:55 AM
> 
> Hi Shimoda-san,
> 
> On Mon, Oct 5, 2015 at 2:06 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > +bool xhci_rcar_is_compatible(struct usb_hcd *hcd)
> > +{
> > +       struct device_node *of_node = hcd->self.controller->of_node;
> > +
> > +       if (of_device_is_compatible(of_node, "renesas,xhci-r8a7790") ||
> > +           of_device_is_compatible(of_node, "renesas,xhci-r8a7791"))
> > +               return true;
> 
> If you want to match against multiple compatible values, you may be better
> off with of_match_node().
> This may also simplify the code to match specific firmware paths to the
> various compatible entries.

Thank you for the comment.
I will modify the code using of_match_node().

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux