Re: [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 30, 2015 at 11:11:52AM -0500, Felipe Balbi wrote:
> On Tue, Sep 22, 2015 at 08:40:23PM +0200, Krzysztof Opasiak wrote:
> > Since:
> > 
> > commit e0857ce58e8658657f5f12fe25272b93cfeb16aa
> 
> this should be something like:
> 
> Since commit e0857ce58e86 (" .... ")
> 
> > ("usb: gadget: loopback: don't queue requests to bogus endpoints")
> > 
> > Loopback function is not realy working as that commit removed
> > all looping back logic. After that commit ep-out works like
> > /dev/null and ep-in works like /dev/zero.
> > 
> > This commit fix this issue by allocating set of out requests
> > and set of in requests but each out req shares buffer with
> > one in req:
> > 
> > out_req->buf ---> buf <--- in_req.buf
> > out_req->context <---> in_req.context
> > 
> > The completion routine simply  enqueue the suitable req in
> > an oposite direction.
> > 
> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.18+
> 
> missing Fixes: e0857ce58e86 ("...")
> 
> I'll fix both while applying, but make sure to make this proper
> next time.

actually fails to apply to v4.3-rc3, please rebase.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux