Re: [PATCH v12 1/7] usb: interface authorization: Declare authorized attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 09/28/2015 09:26 PM, Stefan Koch wrote:
The attribute authorized shows the authorization state for an interface.

Signed-off-by: Stefan Koch <stefan.koch10@xxxxxxxxx>
---
  include/linux/usb.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/linux/usb.h b/include/linux/usb.h
index 447fe29..a2068d7 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -122,6 +122,7 @@ enum usb_interface_condition {
   *	has been deferred.
   * @needs_binding: flag set when the driver should be re-probed or unbound
   *	following a reset or suspend operation it doesn't support.
+ * @authorized: this flag determines if the USB interface will be authorized

Shouldn't this be written in a present tense rather than future?
I mean:

...is authorized

Moreover it would be nice if you could write anything what is it for, not only that authorized attribute determines if interface is authorized as this doesn't carry any useful information. See just a line above, you have a very good example how to do it well:)

Cheers,
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux