Re: [PATCH 1/2] tcm_usb_gadget: Don't strip off nexus WWPN prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 27, 2015 at 03:16:44AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> 
> Avoid stripping off the 'naa.' I_T nexus prefix from configfs
> attribute store input, so that user-space will get back what
> it originaly wrote into ../usb_gadget/$WWPN/$TPGT/nexus.
> 
> Note the SCSI initiator WWPN is purely symbolic for UAS + BOT,
> so it will not effect host side code.
> 
> Reported-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> Cc: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>

please, make sure to Cc myself for anything drivers/usb/gadget:

Acked-by: Felipe Balbi <balbi@xxxxxx>

> ---
>  drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/legacy/tcm_usb_gadget.c b/drivers/usb/gadget/legacy/tcm_usb_gadget.c
> index c3c4808..b764e91 100644
> --- a/drivers/usb/gadget/legacy/tcm_usb_gadget.c
> +++ b/drivers/usb/gadget/legacy/tcm_usb_gadget.c
> @@ -1665,7 +1665,7 @@ static ssize_t tcm_usbg_tpg_store_nexus(
>  	if (i_port[strlen(i_port) - 1] == '\n')
>  		i_port[strlen(i_port) - 1] = '\0';
>  
> -	ret = tcm_usbg_make_nexus(tpg, &i_port[4]);
> +	ret = tcm_usbg_make_nexus(tpg, &i_port[0]);
>  	if (ret < 0)
>  		return ret;
>  	return count;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux