On Fri, 2015-09-25 at 06:49 -0700, Christoph Hellwig wrote: > This also allows to remove the target-specific old configfs macros, and > gets rid of the target_core_fabric_configfs.h header which only had one > function declaration left that could be moved to a better place. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > Documentation/target/tcm_mod_builder.py | 17 - > drivers/infiniband/ulp/srpt/ib_srpt.c | 78 +- > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 153 ++-- > drivers/target/iscsi/iscsi_target_configfs.c | 791 ++++++----------- > drivers/target/iscsi/iscsi_target_stat.c | 666 ++++++-------- > drivers/target/loopback/tcm_loop.c | 60 +- > drivers/target/sbp/sbp_target.c | 87 +- > drivers/target/target_core_configfs.c | 1209 ++++++++++---------------- > drivers/target/target_core_fabric_configfs.c | 275 ++---- > drivers/target/target_core_internal.h | 3 + > drivers/target/target_core_stat.c | 918 ++++++++----------- > drivers/target/tcm_fc/tfc_cmd.c | 1 - > drivers/target/tcm_fc/tfc_conf.c | 44 +- > drivers/target/tcm_fc/tfc_io.c | 1 - > drivers/target/tcm_fc/tfc_sess.c | 1 - > drivers/usb/gadget/legacy/tcm_usb_gadget.c | 44 +- > drivers/vhost/scsi.c | 41 +- > drivers/xen/xen-scsiback.c | 32 +- > include/target/configfs_macros.h | 147 ---- > include/target/target_core_base.h | 60 ++ > include/target/target_core_fabric_configfs.h | 122 --- > 21 files changed, 1689 insertions(+), 3061 deletions(-) > delete mode 100644 include/target/configfs_macros.h > delete mode 100644 include/target/target_core_fabric_configfs.h > I'm totally crazy for this patch. Very nice work to drop this much boilerplate macro-fu in target-core + fabric driver code. Reviewed-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> Acked-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
