Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Hans,

On 10-09-15 20:23, Hans de Goede wrote:
Hi,

On 04-09-15 08:43, Olliver Schinagl wrote:
Hey Hans,

On 07-08-15 10:45, Olliver Schinagl wrote:
<snip>
If you change the dr_mode to host then you _must_ also remove any id_det and vbus_det gpio settings from the usb_phy node in the dts, as the sun4i phy code detects
host vs otg mode by checking for the presence of these.
Yes, this fixes it and makes it work. Thanks.

I've been going back to this and am wondering if this is something I can look into to fix properly? E.g. if the dts sets dr_mode = host, can we simply ignore the pins and treat them as unset?

AFAIK you cannot unset something in dts. The only solution I
can comeup with is to add a dr_mode argument to the phy like
we already have for the otg controller itself.
Actually, it seems that you can :)


&usbphy {
    /* Unset otg detect pins as we force dr_mode */
    /delete-property/ usb0_id_det-gpio;
    /delete-property/ usb0_vbus_det-gpio;
};

is what i am using at the moment.

This is something which we likely need to do anyways to add
support for peripheral only mode, which we seem to need for
some "hdmi sticks".

Patches doing this are welcome from my pov.
While my plate is uite fullish too, i may look into it :)

Regards,

Hans


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux