Proper error handling was done in the probe and some unwanted comparison was removed. Also some forward declaration was removed. regards sudip Sudip Mukherjee (12): usb: gadget: amd5536udc: rewrite init_dma_pools usb: gadget: amd5536udc: fix error path usb: gadget: amd5536udc: use WARN_ON usb: gadget: amd5536udc: use free_dma_pools usb: gadget: amd5536udc: remove unnecessary conditions usb: gadget: amd5536udc: remove forward declaration of udc_probe usb: gadget: amd5536udc: remove forward declaration of udc_remote_wakeup usb: gadget: amd5536udc: remove forward declaration of udc_create_dma_chain usb: gadget: amd5536udc: remove forward declaration of udc_free_dma_chain usb: gadget: amd5536udc: remove forward declaration of udc_pci_* usb: gadget: amd5536udc: remove forward declaration of udc_basic_init usb: gadget: amd5536udc: NULL comparison drivers/usb/gadget/udc/amd5536udc.c | 609 ++++++++++++++++++------------------ drivers/usb/gadget/udc/amd5536udc.h | 5 +- 2 files changed, 301 insertions(+), 313 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html