Re: [PATCH v3] usb: dwc2: Use platform endianness when accessing registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 18, 2015 at 06:54:56PM +0000, John Youn wrote:
> On 9/18/2015 11:50 AM, Felipe Balbi wrote:
> > On Thu, Aug 27, 2015 at 12:10:24AM +0000, John Youn wrote:
> >> On 8/20/2015 11:43 AM, Antti Seppälä wrote:
> >>> This patch switches calls to readl/writel to their
> >>> dwc2_readl/dwc2_writel equivalents which preserve platform endianness.
> >>>
> >>> This patch is necessary to access dwc2 registers correctly on big-endian
> >>> systems such as the mips based SoCs made by Lantiq. Then dwc2 can be
> >>> used to replace ifx-hcd driver for Lantiq platforms found e.g. in
> >>> OpenWrt.
> >>>
> >>> The patch was autogenerated with the following commands:
> >>> $EDITOR core.h
> >>> sed -i "s/\<readl\>/dwc2_readl/g" *.c hcd.h hw.h
> >>> sed -i "s/\<writel\>/dwc2_writel/g" *.c hcd.h hw.h
> >>>
> >>> Some files were then hand-edited to fix checkpatch.pl warnings about
> >>> too long lines.
> >>>
> >>> Signed-off-by: Antti Seppälä <a.seppala@xxxxxxxxx>
> >>> Signed-off-by: Vincent Pelletier <plr.vincent@xxxxxxxxx>
> >>> ---
> >>>
> >>> Notes:
> >>>     Changes in v2:
> >>>      - Fixed wrong comment style
> >>>     
> >>>     Changes in v3
> >>>      - Rebased against latest linux-next
> >>>      - Tweaked indentation in some files
> >>>
> >>>  drivers/usb/dwc2/core.c      | 469 ++++++++++++++++++++++---------------------
> >>>  drivers/usb/dwc2/core.h      |  28 ++-
> >>>  drivers/usb/dwc2/core_intr.c |  73 +++----
> >>>  drivers/usb/dwc2/debugfs.c   |  52 ++---
> >>>  drivers/usb/dwc2/gadget.c    | 314 ++++++++++++++---------------
> >>>  drivers/usb/dwc2/hcd.c       | 140 ++++++-------
> >>>  drivers/usb/dwc2/hcd.h       |  15 +-
> >>>  drivers/usb/dwc2/hcd_ddma.c  |  10 +-
> >>>  drivers/usb/dwc2/hcd_intr.c  |  82 ++++----
> >>>  drivers/usb/dwc2/hcd_queue.c |  10 +-
> >>>  10 files changed, 606 insertions(+), 587 deletions(-)
> >>>
> >>
> >> Acked-by: John Youn <johnyoun@xxxxxxxxxxxx>
> >>
> >>
> >> Hi Felipe,
> >>
> >> Can you queue this for 4.4? I can remind you after the merge
> >> window.
> > 
> > okay, this doesn't apply anymore. We need a refresh on top of
> > my testing/next.
> > 
> 
> I have just fixed this up locally on your testing/next
> intending to resend. It is also based on your s3c->dwc2
> patch. I will send shortly.

thanks :-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux