Hi, On Thu, Sep 17, 2015 at 12:41 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> + spin_unlock_irqrestore(&hsotg->lock, flags); >> + >> + msleep(USB_RESUME_TIMEOUT); >> + >> + spin_lock_irqsave(&hsotg->lock, flags); >> + hprt0 &= ~HPRT0_RES; >> + writel(hprt0, hsotg->regs + HPRT0); > > Just curious: since you released and re-grabbed the lock, shouldn't > you re-read HPRT0? > > Also: one thing that was added in my local tree here was to make > things parallel to dwc2_port_suspend() and update "hsotg->lx_state" > here. I'm not sure if it was added it because there as a real issue > or if it just seemed better... LOL. That will teach me. I just got to the next patch and see that you removed it from dwc2_port_suspend(). Sorry for the noise. I'll try to read more of the series before I respond more... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
