On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch in is. Youtube videos and documentation only get you so far. > > >From reading your response, should I refrain from sending in these > micro-optimizations in future? Getting in smaller patches is easier > for me as I only do this in my spare time, which I don't have a lot > of! micro-optimizations are great, if you can actually measure them and they matter :) If you are looking for someplace to start, might I recommend the drivers/staging/ directory? I take all sorts of "basic" cleanup patches, and there are loads of things to do in there. Look at the drivers/staging/*/TODO files for specific examples of what needs to be done to get these files cleaned up and fixed properly. Hope this helps, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html